[
https://issues.apache.org/jira/browse/HADOOP-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238935#comment-13238935
]
Aaron T. Myers commented on HADOOP-8206:
----------------------------------------
bq. Tried to do this, but these inner classes are really just grouping of
methods inside ZKFC. They access so many of the outer class's variables that it
didn't seem any cleaner to make them static here.
Makes sense. Thanks for looking into it.
bq. Changed to IllegalArgumentException – since from the perspective of ZK, the
state is an argument of the callback, rather than its own state.
Makes sense to me. One question, though - we seem to be inconsistently using
IllegalArgumentException and HadoopIllegalArgumentException. Is there any good
reason for that?
bq. I think you misread it. It is case-insensitive. Clarified the javadoc to
note this.
So I did! My mistake.
bq. I kept having cognitive dissonance when the logs told me something about
"service 1" and I had to actually look at the code referring to svc2. Is that
OK?
Sure, makes sense.
bq. I couldn't use "setUp" since the base class already has that. Changed to
setupConfAndServices and renamed setupServicesAndFCs to just setupFCs which is
more accurate.
Makes sense.
bq. Changed to start them at 2 (didn't start with 1, since that's the error
code that Java returns for uncaught exceptions coming out of main())
Good idea.
bq. Added a new test case testZooKeeperFailure()
Thanks. The new test looks great to me.
+1 pending Jenkins and an answer to the question above about IllegalArgEx.
> Common portion of ZK-based failover controller
> ----------------------------------------------
>
> Key: HADOOP-8206
> URL: https://issues.apache.org/jira/browse/HADOOP-8206
> Project: Hadoop Common
> Issue Type: New Feature
> Components: ha
> Affects Versions: 0.24.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: hadoop-8206.txt, hadoop-8206.txt, hadoop-8206.txt
>
>
> This JIRA is for the Common (generic) portion of HDFS-2185. It can't run on
> its own, but this JIRA will include unit tests using mock/dummy services.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
