[ https://issues.apache.org/jira/browse/HADOOP-14954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17802959#comment-17802959 ]
Shilun Fan commented on HADOOP-14954: ------------------------------------- Bulk update: moved all 3.4.0 non-blocker issues, please move back if it is a blocker. Retarget 3.5.0. > MetricsSystemImpl#init should increment refCount when already initialized > ------------------------------------------------------------------------- > > Key: HADOOP-14954 > URL: https://issues.apache.org/jira/browse/HADOOP-14954 > Project: Hadoop Common > Issue Type: Bug > Components: metrics > Affects Versions: 2.7.0 > Reporter: John Zhuge > Assignee: John Zhuge > Priority: Minor > Attachments: HADOOP-14954.001.patch, HADOOP-14954.002.patch, > HADOOP-14954.002a.patch > > > {{++refCount}} here in {{init}} should be symmetric to {{--refCount}} in > {{shutdown}}. > {code:java} > public synchronized MetricsSystem init(String prefix) { > if (monitoring && !DefaultMetricsSystem.inMiniClusterMode()) { > LOG.warn(this.prefix +" metrics system already initialized!"); > return this; > } > this.prefix = checkNotNull(prefix, "prefix"); > ++refCount; > {code} > Move {{++refCount}} to the beginning of this method. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org