[ https://issues.apache.org/jira/browse/HADOOP-8218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239191#comment-13239191 ]
Hadoop QA commented on HADOOP-8218: ----------------------------------- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12520063/hadoop-8218.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 11 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/790//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/790//console This message is automatically generated. > RPC.closeProxy shouldn't throw error when closing a mock > -------------------------------------------------------- > > Key: HADOOP-8218 > URL: https://issues.apache.org/jira/browse/HADOOP-8218 > Project: Hadoop Common > Issue Type: Bug > Components: ipc, test > Affects Versions: 0.24.0 > Reporter: Todd Lipcon > Assignee: Todd Lipcon > Priority: Critical > Attachments: hadoop-8218.txt, hadoop-8218.txt > > > HADOOP-8202 changed the behavior of RPC.stopProxy() to throw an exception if > called on an object which doesn't implement Closeable. Unfortunately, we use > mock objects in many test cases, and those mocks don't implement Closeable. > This is causing TestZKFailoverController to fail in trunk, for example. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira