hfutatzhanghb commented on PR #6434: URL: https://github.com/apache/hadoop/pull/6434#issuecomment-1897837901
> Line211 has already ensured that we have a monitor for this object: > > https://github.com/apache/hadoop/blob/ba6ada73acc2bce560878272c543534c21c76f22/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogAsync.java#L211-L223 > > > So, I think the description in this PR is not a problem. What's your opinion? @hfutatzhanghb @zhangshuyan0 Sir, `this.wait(1000);` is in do-while loop, when we invoke `this.wait(1000)` at first time, it will release object monitor. But in extreme situation, it will throw Exception when invoke `this.wait(1000)` at the second time, because current thread does not hold the object monitor. Waiting for your response~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
