[
https://issues.apache.org/jira/browse/HADOOP-8149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240803#comment-13240803
]
Hadoop QA commented on HADOOP-8149:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12520335/HADOOP-8149.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/794//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/794//console
This message is automatically generated.
> cap space usage of default log4j rolling policy
> ------------------------------------------------
>
> Key: HADOOP-8149
> URL: https://issues.apache.org/jira/browse/HADOOP-8149
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Attachments: HADOOP-8149.patch, HADOOP-8149.patch, HADOOP-8149.patch,
> HADOOP-8149.patch, HADOOP-8149.patch
>
>
> I've seen several critical production issues because logs are not
> automatically removed after some time and accumulate. Changes to Hadoop's
> default log4j file appender would help with this.
> I recommend we move to an appender which:
> 1) caps the max file size (configurable)
> 2) caps the max number of files to keep (configurable)
> 3) uses rolling file appender rather than DRFA, see the warning here:
> http://logging.apache.org/log4j/1.2/apidocs/org/apache/log4j/DailyRollingFileAppender.html
> Specifically: "DailyRollingFileAppender has been observed to exhibit
> synchronization issues and data loss."
> We'd lose (based on the default log4j configuration) the daily rolling
> aspect, however increase reliability.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
