goiri commented on code in PR #6491:
URL: https://github.com/apache/hadoop/pull/6491#discussion_r1465602892
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterRpc.java:
##########
@@ -2074,9 +2074,6 @@ public void testMkdirsWithCallerContext() throws
IOException {
GenericTestUtils.LogCapturer auditlog =
GenericTestUtils.LogCapturer.captureLogs(FSNamesystem.AUDIT_LOG);
- // Current callerContext is null
- assertNull(CallerContext.getCurrent());
Review Comment:
Why can't we check this?
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterRpcMultiDestination.java:
##########
@@ -475,7 +475,7 @@ public void testCallerContextWithMultiDestinations() throws
IOException {
String auditFlag = "src=" + dirPath.toString();
String clientIpInfo = "clientIp:"
- + InetAddress.getLocalHost().getHostAddress();
+ + InetAddress.getByName("localhost").getHostAddress();
Review Comment:
Is this multiplatform or will only work on Linux?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
