hfutatzhanghb commented on code in PR #6502:
URL: https://github.com/apache/hadoop/pull/6502#discussion_r1467398721
##########
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/net/NioInetPeer.java:
##########
@@ -91,7 +91,11 @@ public void close() throws IOException {
try {
in.close();
} finally {
- out.close();
+ try {
+ out.close();
+ } finally {
+ socket.close();
+ }
Review Comment:
@LiuGuH Hi, Leave one comment. Please check DFSUtilClient#peerFromSocket.
https://github.com/apache/hadoop/blob/897f446d54315b70754eb8023cf195c902bca98e/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSUtilClient.java#L799
Should we better set keep-alive time here or not ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
