hfutatzhanghb opened a new pull request, #6503: URL: https://github.com/apache/hadoop/pull/6503
### Description of PR Refer to HDFS-17359 In method DFSStripedOutputStream#checkStreamerFailures, we have below codes: ```java Set<StripedDataStreamer> newFailed = checkStreamers(); if (newFailed.size() == 0) { return; } if (isNeedFlushAllPackets) { // for healthy streamers, wait till all of them have fetched the new block // and flushed out all the enqueued packets. flushAllInternals(); } // recheck failed streamers again after the flush newFailed = checkStreamers(); ``` We should better move the re-check logic into if condition to reduce useless invocation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org