[
https://issues.apache.org/jira/browse/HADOOP-17350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17812097#comment-17812097
]
ASF GitHub Bot commented on HADOOP-17350:
-----------------------------------------
jxhan3 commented on PR #6506:
URL: https://github.com/apache/hadoop/pull/6506#issuecomment-1915874253
> The patch doesn't appear to include any new or modified tests. Please
justify why no new tests are needed for this patch. Also please list what
manual steps were performed to verify this patch.
This PR only updates the AWS SDK, there is no new feature or other code
logic change. There is no need for new tests.
> hadoop: flag native changes w/no Dockerfile change
> --------------------------------------------------
>
> Key: HADOOP-17350
> URL: https://issues.apache.org/jira/browse/HADOOP-17350
> Project: Hadoop Common
> Issue Type: Improvement
> Components: precommit
> Reporter: Unassigned Developer
> Priority: Minor
> Labels: pull-request-available
>
> Issues like HADOOP-13578 are a textbook example of where a large number of
> issue followers and reviewers (some of whom are experienced PMC members)
> completely missed the fact that very little of the added native code is
> actually being compiled, tested, or even in the release because the
> Dockerfile wasn't modified to include new prerequisites. We should probably
> enhance the hadoop personality to -1 such patches.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
