[ 
https://issues.apache.org/jira/browse/HADOOP-18980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813403#comment-17813403
 ] 

ASF GitHub Bot commented on HADOOP-18980:
-----------------------------------------

virajjasani commented on code in PR #6406:
URL: https://github.com/apache/hadoop/pull/6406#discussion_r1475136032


##########
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/aws_sdk_upgrade.md:
##########
@@ -66,6 +66,25 @@ The change in interface will mean that custom credential 
providers will need to
 implement `software.amazon.awssdk.auth.credentials.AwsCredentialsProvider` 
instead of
 `com.amazonaws.auth.AWSCredentialsProvider`.
 
+[HADOOP-18980](https://issues.apache.org/jira/browse/HADOOP-18980) introduces 
extended version of
+the credential provider remapping. `fs.s3a.aws.credentials.provider.mapping` 
can be used to
+list comma-separated key-value pairs of mapped credential providers that are 
separated by
+equal operator (=). The key can be used by `fs.s3a.aws.credentials.provider` 
config, and it
+will be translated into the specified value of credential provider class based 
on the key-value
+pair provided by this config.
+
+For example, if `fs.s3a.aws.credentials.provider.mapping` is set with value:
+

Review Comment:
   Just tried xml snippet to see how it looks and actually it looks better 
because now the example is much clear. Please let me know what you think of the 
latest revision.





> S3A credential provider remapping: make extensible
> --------------------------------------------------
>
>                 Key: HADOOP-18980
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18980
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 3.4.0
>            Reporter: Steve Loughran
>            Assignee: Viraj Jasani
>            Priority: Minor
>              Labels: pull-request-available
>
> s3afs will now remap the common com.amazonaws credential providers to 
> equivalents in the v2 sdk or in hadoop-aws
> We could do the same for third party credential providers by taking a 
> key=value list in a configuration property and adding to the map. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to