xinglin commented on code in PR #6519:
URL: https://github.com/apache/hadoop/pull/6519#discussion_r1476377287
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java:
##########
@@ -1081,31 +1081,32 @@ private synchronized void sendPing() throws IOException
{
@Override
public void run() {
- // Don't start the ipc parameter sending thread until we start this
- // thread, because the shutdown logic only gets triggered if this
- // thread is started.
- rpcRequestThread.start();
- if (LOG.isDebugEnabled())
- LOG.debug(getName() + ": starting, having connections "
- + connections.size());
-
try {
+ // Don't start the ipc parameter sending thread until we start this
+ // thread, because the shutdown logic only gets triggered if this
+ // thread is started.
+ rpcRequestThread.start();
+ if (LOG.isDebugEnabled()) {
+ LOG.debug(getName() + ": starting, having connections " +
connections.size());
+ }
+
while (waitForWork()) {//wait here for work - read or close connection
receiveRpcResponse();
}
} catch (Throwable t) {
// This truly is unexpected, since we catch IOException in
receiveResponse
// -- this is only to be really sure that we don't leave a client
hanging
// forever.
- LOG.warn("Unexpected error reading responses on connection " + this,
t);
- markClosed(new IOException("Error reading responses", t));
+ String msg = String.format("Unexpected error on connection %s. Closing
it.", this);
+ LOG.warn(msg, t);
+ markClosed(new IOException(msg, t));
}
-
+
close();
-
- if (LOG.isDebugEnabled())
- LOG.debug(getName() + ": stopped, remaining connections "
- + connections.size());
+
+ if (LOG.isDebugEnabled()) {
+ LOG.debug(getName() + ": stopped, remaining connections " +
connections.size());
+ }
Review Comment:
reverted but I guess we will keep the curly brackets here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
