slfan1989 commented on code in PR #29:
URL: https://github.com/apache/hadoop-thirdparty/pull/29#discussion_r1476920146
##########
dev-support/bin/create-release:
##########
@@ -441,9 +441,9 @@ function dockermode
echo "LABEL org.apache.hadoop.create-release=\"cr-${RANDOM}\""
# setup ownerships, etc
- echo "RUN groupadd --non-unique -g ${group_id} ${user_name}"
- echo "RUN useradd -g ${group_id} -u ${user_id} -m ${user_name}"
- echo "RUN chown -R ${user_name} /home/${user_name}"
+ echo "RUN groupadd --non-unique -g ${group_id} ${user_name}; exit 0;"
Review Comment:
@Hexiaoqiao Thank you for reviewing the code!
We have improved the hadoop script at
https://github.com/apache/hadoop/pull/6448. I think hadoop-thirdparty should
also be improved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
