steveloughran commented on code in PR #6301:
URL: https://github.com/apache/hadoop/pull/6301#discussion_r1477078046
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AUtils.java:
##########
@@ -1670,4 +1670,25 @@ public static String formatRange(long rangeStart, long
rangeEnd) {
return String.format("bytes=%d-%d", rangeStart, rangeEnd);
}
+
+ /**
+ * If classloader isolation is {@code true}
+ * (through {@link Constants#AWS_S3_CLASSLOADER_ISOLATION}) or not
+ * explicitly set, then the classLoader of the input configuration object
+ * will be set to the input classloader, otherwise nothing will happen.
+ * @param conf configuration object.
+ * @param classLoader isolated classLoader.
+ */
+ static void isolateClassloader(Configuration conf, ClassLoader classLoader) {
Review Comment:
let's rename this "maybeIsolateClassloader" to make clear it is conditional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
