bpahuja commented on PR #6407: URL: https://github.com/apache/hadoop/pull/6407#issuecomment-1929172260
> I 'd go for getTrimmed(READ_RESTORED_GLACIER_OBJECTS, ""); if empty string map to empty optional, otherwise .toupper and valueof. one thing to consider: meaningful failure if the value doesn't map. > or we just go for "upper case is required" and use what you've proposed. more brittle but simpler? Regarding the above, I will update the config read to getTrimmed and set the config values of defualt to READ_ALL instead of "". > meaningful failure if the value doesn't map the valueof method will throw the illegalArgs exception if an invalid value is set in the config -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
