[ https://issues.apache.org/jira/browse/HADOOP-18830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815359#comment-17815359 ]
ASF GitHub Bot commented on HADOOP-18830: ----------------------------------------- hadoop-yetus commented on PR #6523: URL: https://github.com/apache/hadoop/pull/6523#issuecomment-1932467536 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |:----:|----------:|--------:|:--------:|:-------:| | +0 :ok: | reexec | 4m 30s | | Docker mode activated. | |||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. | | +0 :ok: | codespell | 0m 0s | | codespell was not available. | | +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. | | +0 :ok: | markdownlint | 0m 0s | | markdownlint was not available. | | +0 :ok: | xmllint | 0m 0s | | xmllint was not available. | | +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 11 new or modified test files. | |||| _ branch-3.3 Compile Tests _ | | +1 :green_heart: | mvninstall | 33m 31s | | branch-3.3 passed | | +1 :green_heart: | compile | 0m 24s | | branch-3.3 passed | | +1 :green_heart: | checkstyle | 0m 21s | | branch-3.3 passed | | +1 :green_heart: | mvnsite | 0m 28s | | branch-3.3 passed | | +1 :green_heart: | javadoc | 0m 24s | | branch-3.3 passed | | +1 :green_heart: | spotbugs | 0m 51s | | branch-3.3 passed | | +1 :green_heart: | shadedclient | 21m 49s | | branch has no errors when building and testing our client artifacts. | |||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 0m 25s | | the patch passed | | +1 :green_heart: | compile | 0m 21s | | the patch passed | | -1 :x: | javac | 0m 21s | [/results-compile-javac-hadoop-tools_hadoop-aws.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6523/3/artifact/out/results-compile-javac-hadoop-tools_hadoop-aws.txt) | hadoop-tools_hadoop-aws generated 9 new + 23 unchanged - 2 fixed = 32 total (was 25) | | +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. | | +1 :green_heart: | checkstyle | 0m 12s | | hadoop-tools/hadoop-aws: The patch generated 0 new + 6 unchanged - 8 fixed = 6 total (was 14) | | +1 :green_heart: | mvnsite | 0m 25s | | the patch passed | | +1 :green_heart: | javadoc | 0m 17s | | the patch passed | | +1 :green_heart: | spotbugs | 0m 45s | | the patch passed | | +1 :green_heart: | shadedclient | 20m 31s | | patch has no errors when building and testing our client artifacts. | |||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 3s | | hadoop-aws in the patch passed. | | +1 :green_heart: | asflicense | 0m 24s | | The patch does not generate ASF License warnings. | | | | 89m 37s | | | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6523/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/6523 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets markdownlint xmllint | | uname | Linux 24fd4bed0c7b 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/bin/hadoop.sh | | git revision | branch-3.3 / cd085ad42dc71041bdfacc9982b2affe49ea515d | | Default Java | Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~18.04-b09 | | Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6523/3/testReport/ | | Max. process+thread count | 553 (vs. ulimit of 5500) | | modules | C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws | | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6523/3/console | | versions | git=2.17.1 maven=3.6.0 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.14.0 https://yetus.apache.org | This message was automatically generated. > S3A: Cut S3 Select > ------------------ > > Key: HADOOP-18830 > URL: https://issues.apache.org/jira/browse/HADOOP-18830 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/s3 > Affects Versions: 3.4.0 > Reporter: Steve Loughran > Assignee: Steve Loughran > Priority: Major > Labels: pull-request-available > Fix For: 3.5.0, 3.4.1 > > > getting s3 select to work with the v2 sdk is tricky, we need to add extra > libraries to the classpath beyond just bundle.jar. we can do this but > * AFAIK nobody has ever done CSV predicate pushdown, as it breaks split logic > completely > * CSV is a bad format > * one-line JSON more structured but also way less efficient > ORC/Parquet benefit from vectored IO and work spanning the cluster. > accordingly, I'm wondering what to do about s3 select > # cut? > # downgrade to optional and document the extra classes on the classpath > Option #2 is straightforward and effectively the default. we can also declare > the feature deprecated. > {code} > [ERROR] > testReadLandsatRecordsNoMatch(org.apache.hadoop.fs.s3a.select.ITestS3SelectLandsat) > Time elapsed: 147.958 s <<< ERROR! > java.io.IOException: java.lang.NoClassDefFoundError: > software/amazon/eventstream/MessageDecoder > at > org.apache.hadoop.fs.s3a.select.SelectObjectContentHelper.select(SelectObjectContentHelper.java:75) > at > org.apache.hadoop.fs.s3a.WriteOperationHelper.lambda$select$10(WriteOperationHelper.java:660) > at > org.apache.hadoop.fs.store.audit.AuditingFunctions.lambda$withinAuditSpan$0(AuditingFunctions.java:62) > at org.apache.hadoop.fs.s3a.Invoker.once(Invoker.java:122) > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org