[
https://issues.apache.org/jira/browse/HADOOP-6963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246694#comment-13246694
]
Robert Joseph Evans commented on HADOOP-6963:
---------------------------------------------
I can see that, but we need to filter it either by bumping the findbugs count
in hadoop-common-project/dev-support/test-patch.properties
or by adding something to
hadoop-common-project/hadoop-common/pom.xml
similar to
{code}
</plugin>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>findbugs-maven-plugin</artifactId>
<configuration>
<findbugsXmlOutput>true</findbugsXmlOutput>
<xmlOutput>true</xmlOutput>
<excludeFilterFile>${mr.examples.basedir}/dev-support/findbugs-exclude.xml</excludeFilterFile>
<effort>Max</effort>
</configuration>
</plugin>
{code}
I would prefer the second because it is less likely to mask other errors, but I
am fine either way.
Please also update the 1.0.2 patch similarly so test-patch will work there too.
> Fix FileUtil.getDU. It should not include the size of the directory or follow
> symbolic links
> --------------------------------------------------------------------------------------------
>
> Key: HADOOP-6963
> URL: https://issues.apache.org/jira/browse/HADOOP-6963
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.20.205.0, 0.23.1
> Reporter: Owen O'Malley
> Assignee: Ravi Prakash
> Priority: Critical
> Attachments: HADOOP-6963.branch-1.0.2.patch,
> HADOOP-6963.branch-23.patch, HADOOP-6963.branch-23.patch
>
>
> The getDU method should not include the size of the directory. The Java
> interface says that the value is undefined and in Linux/Sun it gets the 4096
> for the inode. Clearly this isn't useful.
> It also recursively calls itself. In case the directory has a symbolic link
> forming a cycle, getDU keeps spinning in the cycle. In our case, we saw this
> in the org.apache.hadoop.mapred.JobLocalizer.downloadPrivateCacheObjects
> call. This prevented other tasks on the same node from committing, causing
> the TT to become effectively useless (because the JT thinks it already has
> enough tasks running)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
