[ 
https://issues.apache.org/jira/browse/HADOOP-19071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819336#comment-17819336
 ] 

ASF GitHub Bot commented on HADOOP-19071:
-----------------------------------------

shahrs87 commented on PR #6537:
URL: https://github.com/apache/hadoop/pull/6537#issuecomment-1957394370

   Thank you @steveloughran  for your response.
   
   > Rather than say "hey, let's revert", I'd propose a "surefire update 
triggers test failures" and see what can be done about addressing them. because 
we can't stay frozen with surefire versions.
   
   I didn't mean to sound rude. Apologies if you felt that way. I understand 
that when upgrading maven, surefire or protobuf's version, it is very 
reasonable to see test failures. But in this case, the jenkins build is not 
running all tests, some of the tests are failing and some of the builds are 
getting stuck for 20-24 hours and is affecting all the developers. I spent 
atleast 2-3 days debugging the test failures assuming that this is caused by my 
patch before posting a 
[message](https://the-asf.slack.com/archives/CAD7C52Q3/p1708118456027809) on 
the slack channel and then @ayushtkn helped me. I am sure other developers have 
followed the same path.
   What I am suggesting is: Lets revert this change, unblock all developers and 
then we raise a new PR with the proposed surefire version change, make sure all 
the tests pass, make test improvements if needed and then push the change to 
trunk branch.
   WDYT? 
   Cc @ayushtkn 




> Update maven-surefire-plugin from 3.0.0 to 3.2.5      
> -------------------------------------------------
>
>                 Key: HADOOP-19071
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19071
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: build, common
>    Affects Versions: 3.4.0, 3.5.0
>            Reporter: Shilun Fan
>            Assignee: Shilun Fan
>            Priority: Major
>              Labels: pull-request-available
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to