zhangshuyan0 commented on code in PR #6509:
URL: https://github.com/apache/hadoop/pull/6509#discussion_r1498565609
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockRecoveryWorker.java:
##########
@@ -436,9 +442,17 @@ protected void recover() throws IOException {
"datanode={})", block, internalBlk, id, e);
}
}
- checkLocations(syncBlocks.size());
- final long safeLength = getSafeLength(syncBlocks);
+ final long safeLength;
+ if (dnNotHaveReplicaCnt + zeroLenReplicaCnt <= locs.length -
ecPolicy.getNumDataUnits()) {
+ checkLocations(syncBlocks.size());
+ safeLength = getSafeLength(syncBlocks);
+ } else {
+ safeLength = 0;
+ LOG.warn("Block recovery: More than {} datanodes do not have the
replica of block {}." +
Review Comment:
Suggest printing out the value of `zeroLenReplicaCnt` as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
