steveloughran commented on code in PR #6575: URL: https://github.com/apache/hadoop/pull/6575#discussion_r1500859099
########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/pom.xml: ########## @@ -72,6 +72,7 @@ <dependency> <groupId>com.google.protobuf</groupId> <artifactId>protobuf-java</artifactId> + <scope>${transient.protobuf2.scope}</scope> Review Comment: 1. The dependent poms (hadoop-common...) aren't publishing it any more, just using it for compilation. 2. I don't trust the base declaration to do the right thing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org