[ 
https://issues.apache.org/jira/browse/HADOOP-18910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821944#comment-17821944
 ] 

ASF GitHub Bot commented on HADOOP-18910:
-----------------------------------------

anujmodi2021 commented on PR #6069:
URL: https://github.com/apache/hadoop/pull/6069#issuecomment-1970491157

   > > You also need to add following test configuration to specify the account 
type you are using `fs.azure.test.namespace.enabled "`
   > > ```
   > > <property>
   > >     <name>fs.azure.test.namespace.enabled</name>
   > >     <value>true</value>
   > > </property>
   > > ```
   > 
   > Yes after adding this, ITestGetNameSpaceEnabled succeed. But shouldn't 
tests be written in a way that either it succeeds or gets skipped if this value 
is not set in auth-keys.xml
   
   Hi Mukund...
   That makes sense. We will take up a WI to skip tests if required configs are 
not set.
   
   Having said that, we recommend that developers making changes in driver, 
should follow the configuration template we have designed so that they do not 
end up skipping a lot of tests. Recommendation is to follow the template and 
set all the configs mentioned there and then use our test scripts to run the 
whole test suite. That will ensure easy test runs with all the combinations of 
account types and auth types..
   
   We will also make sure to update the documentations regarding ABFS Testing 
with this recommendation.
   
   Thanks for pointing this out.




> ABFS: Adding Support for MD5 Hash based integrity verification of the request 
> content during transport 
> -------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-18910
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18910
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/azure
>            Reporter: Anuj Modi
>            Assignee: Anuj Modi
>            Priority: Major
>              Labels: pull-request-available
>
> Azure Storage Supports Content-MD5 Request Headers in Both Read and Append 
> APIs.
> Read: [Path - Read - REST API (Azure Storage Services) | Microsoft 
> Learn|https://learn.microsoft.com/en-us/rest/api/storageservices/datalakestoragegen2/path/read]
> Append: [Path - Update - REST API (Azure Storage Services) | Microsoft 
> Learn|https://learn.microsoft.com/en-us/rest/api/storageservices/datalakestoragegen2/path/update]
> This change is to make client-side changes to support them. In Read request, 
> we will send the appropriate header in response to which server will return 
> the MD5 Hash of the data it sends back. On Client we will tally this with the 
> MD5 hash computed from the data received.
> In Append request, we will compute the MD5 Hash of the data that we are 
> sending to the server and specify that in appropriate header. Server on 
> finding that header will tally this with the MD5 hash it will compute on the 
> data received. 
> This whole Checksum Validation Support is guarded behind a config, Config is 
> by default disabled because with the use of "https" integrity of data is 
> preserved anyways. This is introduced as an additional data integrity check 
> which will have a performance impact as well.
> Users can decide if they want to enable this or not by setting the following 
> config to *"true"* or *"false"* respectively. *Config: 
> "fs.azure.enable.checksum.validation"*



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to