tasanuma commented on code in PR #6566:
URL: https://github.com/apache/hadoop/pull/6566#discussion_r1512884161
##########
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java:
##########
@@ -1817,10 +1839,10 @@ protected LocatedBlock nextBlockOutputStream() throws
IOException {
nodes = lb.getLocations();
nextStorageTypes = lb.getStorageTypes();
nextStorageIDs = lb.getStorageIDs();
-
+ setPipeline(lb);
// Connect to first DataNode in the list.
success = createBlockOutputStream(nodes, nextStorageTypes,
nextStorageIDs,
- 0L, false);
+ 0L, false) || setupPipelineForAppendOrRecovery();
Review Comment:
I haven't looked into the PR in detail, but it makes sense to me that
PIPELINE_SETUP_CREATE should also consider the
`dtpReplaceDatanodeOnFailureReplication`. If I understand correctly, this
change won't affect users who have set
`dfs.client.block.write.replace-datanode-on-failure.min-replication(=dtpReplaceDatanodeOnFailureReplication)=0`,
which is the default setting, so I think it's fairly safe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
