ahmarsuhail commented on PR #6164: URL: https://github.com/apache/hadoop/pull/6164#issuecomment-1983551593
Thanks @steveloughran . While looking at the test failures, I found a couple of issues with S3 Encryption Client, opened https://github.com/aws/amazon-s3-encryption-client-java/issues/200 and https://github.com/aws/amazon-s3-encryption-client-java/issues/201 there. `ITestS3AContractVectoredRead.testEOFRanges416Handling` fails because S3EC does not throw an exception is range is greater than EOF. `ITestConnectionTimeouts.testGeneratePoolTimeouts` fails because S3EC uses the async client to make requests, and the error thrown on a timeout is different. S3Client will throw ``` software.amazon.awssdk.core.exception.SdkClientException: Unable to execute HTTP request Caused by: software.amazon.awssdk.thirdparty.org.apache.http.conn.ConnectTimeoutException Caused by: java.net.SocketTimeoutException: connect timed out ``` which gets translated to `ConnectTimeoutException` in S3AUtils.translateInterruptedException(). But AsynClient throws: ``` software.amazon.awssdk.core.exception.SdkClientException: Unable to execute HTTP request: Caused by: java.lang.Throwable: Acquire operation took longer than the configured maximum time. Causes by: java.util.concurrent.TimeoutException: Acquire operation took longer than 10 milliseconds. ``` which currently doesn't get translated properly, so need to add some handling there. Will wait for the fixes to S3EC, and then update error translation + address comments. Also asked about adding it to bundle. Looking at S3EC dependencies, I think it may cause us some issues, but not sure: ``` [INFO] +- software.amazon.encryption.s3:amazon-s3-encryption-client-java:jar:3.1.1:provided [INFO] | +- software.amazon.awssdk:s3:jar:2.20.38:provided [INFO] | | +- software.amazon.awssdk:aws-xml-protocol:jar:2.20.38:provided [INFO] | | | \- software.amazon.awssdk:aws-query-protocol:jar:2.20.38:provided [INFO] | | +- software.amazon.awssdk:protocol-core:jar:2.20.38:provided [INFO] | | +- software.amazon.awssdk:arns:jar:2.20.38:provided [INFO] | | +- software.amazon.awssdk:profiles:jar:2.20.38:provided [INFO] | | +- software.amazon.awssdk:crt-core:jar:2.20.38:provided [INFO] | | +- software.amazon.awssdk:sdk-core:jar:2.20.38:provided [INFO] | | | \- org.reactivestreams:reactive-streams:jar:1.0.3:provided [INFO] | | +- software.amazon.awssdk:auth:jar:2.20.38:provided [INFO] | | | \- software.amazon.eventstream:eventstream:jar:1.0.1:provided [INFO] | | +- software.amazon.awssdk:http-client-spi:jar:2.20.38:provided [INFO] | | +- software.amazon.awssdk:regions:jar:2.20.38:provided [INFO] | | +- software.amazon.awssdk:annotations:jar:2.20.38:provided [INFO] | | +- software.amazon.awssdk:utils:jar:2.20.38:provided [INFO] | | +- software.amazon.awssdk:aws-core:jar:2.20.38:provided [INFO] | | +- software.amazon.awssdk:metrics-spi:jar:2.20.38:provided [INFO] | | +- software.amazon.awssdk:json-utils:jar:2.20.38:provided [INFO] | | | \- software.amazon.awssdk:third-party-jackson-core:jar:2.20.38:provided [INFO] | | +- software.amazon.awssdk:endpoints-spi:jar:2.20.38:provided [INFO] | | +- software.amazon.awssdk:apache-client:jar:2.20.38:provided [INFO] | | \- software.amazon.awssdk:netty-nio-client:jar:2.20.38:provided [INFO] | +- joda-time:joda-time:jar:2.8.1:provided [INFO] | \- commons-logging:commons-logging:jar:1.2:provided ``` What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
