RuinanGu commented on PR #6597: URL: https://github.com/apache/hadoop/pull/6597#issuecomment-1988972943
> In` BlockManager.java`the variable `logEmptyExcessType` seems unused can remove? This parameter is added in [https://github.com/apache/hadoop/pull/5474](url) (Also a patch I contributed), after the modification of the patch, I dont't think the parameter is neccessary any more, so we can remove it.The "empty exessType" log can be removed too, after the modification of this patch, the exessType is impossible to be null, becase the candidates is > 1 and the "replication"(first parameter of storagePolicy.chooseExcess) is constantly 1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
