mukund-thakur commented on PR #6069: URL: https://github.com/apache/hadoop/pull/6069#issuecomment-1989236236
> > > You also need to add following test configuration to specify the account type you are using `fs.azure.test.namespace.enabled "` > > > ``` > > > <property> > > > <name>fs.azure.test.namespace.enabled</name> > > > <value>true</value> > > > </property> > > > ``` > > > > > > Yes after adding this, ITestGetNameSpaceEnabled succeed. But shouldn't tests be written in a way that either it succeeds or gets skipped if this value is not set in auth-keys.xml > > Hi @mukund-thakur That makes sense. We will take up a WI to skip tests if required configs are not set. > > Having said that, we recommend that developers making changes in driver, should follow the configuration template we have designed so that they do not end up skipping a lot of tests. Recommendation is to follow the template and set all the configs mentioned there and then use our test scripts to run the whole test suite. That will ensure easy test runs with all the combinations of account types and auth types.. > > We will also make sure to update the documentations regarding ABFS Testing with this recommendation. > > Thanks for pointing this out. Have you created the Jira's for these test issues? Found one more today https://issues.apache.org/jira/browse/HADOOP-19106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
