anmolanmol1234 commented on code in PR #6552:
URL: https://github.com/apache/hadoop/pull/6552#discussion_r1503719618
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemChooseSAS.java:
##########
@@ -97,16 +99,16 @@ public void testBothProviderFixedTokenConfigured() throws
Exception {
// Creating a new file system with updated configs.
try (AzureBlobFileSystem newTestFs = (AzureBlobFileSystem)
FileSystem.newInstance(testAbfsConfig.getRawConfiguration())) {
- TracingContext tracingContext = getTestTracingContext(newTestFs, true);
- // Asserting that filesystem level operations fails with User Delegation
SAS.
- intercept(SASTokenProviderException.class, () -> {
- newTestFs.getAbfsStore().getFilesystemProperties(tracingContext);
- });
+ // Asserting that MockDelegationSASTokenProvider is used.
+ Assertions.assertThat(testAbfsConfig.getSASTokenProvider())
+ .describedAs("Custom SASTokenProvider Class must be used")
+ .isInstanceOf(MockDelegationSASTokenProvider.class);
- // Asserting that User delegation SAS token is otherwise valid and blob
level operations succeed.
- Path testPath = new Path("/testCorrectSASToken");
+ // Assert that User Delegation SAS is used and both read and write
operations are permitted.
+ Path testPath = path(getMethodName());
newTestFs.create(testPath).close();
+ newTestFs.open(testPath).close();
Review Comment:
The testPath is already closed, the need for this additional statement ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
