ritegarg commented on PR #6612: URL: https://github.com/apache/hadoop/pull/6612#issuecomment-1994939750
> @ritegarg Thank you for the PR. Overall looks good. Looks like `blanks` and `spotbugs` warnings are relevant. Can you please fix them? Once that is done, I will approve and merge. I see 2 spotbugs failures 1. Possible null dereference in DFSOutputStream.java:[line 314] -> There is a PreConditions.checkNotNull before that in line 312 2. Redundant Null Check of possible null values PeerCache.java:[line 158] -> Removed the null check Also removed blank line -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
