[
https://issues.apache.org/jira/browse/HADOOP-19128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831183#comment-17831183
]
ASF GitHub Bot commented on HADOOP-19128:
-----------------------------------------
RocMarshal opened a new pull request, #6680:
URL: https://github.com/apache/hadoop/pull/6680
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g.,
'HADOOP-17799. Your PR title ...'.
-->
### Description of PR
- Unified use of placeholder for log calling
- https://issues.apache.org/jira/browse/HADOOP-19128
### How was this patch tested?
N.A
### For code changes:
- [x] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
N.A
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
N.A
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
N.A
> Unified use of placeholder for log calling
> ------------------------------------------
>
> Key: HADOOP-19128
> URL: https://issues.apache.org/jira/browse/HADOOP-19128
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: RocMarshal
> Priority: Minor
>
> There're some classes logging with pure string like 'AMLauncher':
> {code:java}
> LOG.info("Setting up container " + masterContainer
> + " for AM " + application.getAppAttemptId()); {code}
> It would be better use as follows?:
> {code:java}
> LOG.info("Setting up container {} for AM {}", masterContainer,
> application.getAppAttemptId()); {code}
>
> If the community decides to do so, I am happy to contribute to it~
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
