shameersss1 commented on PR #6631: URL: https://github.com/apache/hadoop/pull/6631#issuecomment-2027351500
> waiting to see what hdfs people say; mentioned internally. > > now, there is a way to do this with a smaller diff, specifically, move the IOPair class into hadoop common _but keep with the same package name_. > > something to seriously consider. would reduce the risk of any code elsewhere making explicit use of the class then breaking. That is a great suggestion. It will help to reduce the diff. @steveloughran - i have incoporated that change as well in the new revision. I have not heard from HDFS community so far. I suppose "no news is good news". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
