[ https://issues.apache.org/jira/browse/HADOOP-19134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832466#comment-17832466 ]
ASF GitHub Bot commented on HADOOP-19134: ----------------------------------------- pjfanning opened a new pull request, #6692: URL: https://github.com/apache/hadoop/pull/6692 ### Description of PR HADOOP-19134 ### How was this patch tested? ### For code changes: - [x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')? - [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files? > use StringBuilder instead of StringBuffer > ----------------------------------------- > > Key: HADOOP-19134 > URL: https://issues.apache.org/jira/browse/HADOOP-19134 > Project: Hadoop Common > Issue Type: Improvement > Reporter: PJ Fanning > Priority: Major > > StringBuilder is basically the same as StringBuffer but doesn't use > synchronized. String appending rarely needs locking like this. > There are some public and package private APIs that use StringBuffers as > input or return types - I have left these alone for compatibility reasons. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org