[ 
https://issues.apache.org/jira/browse/HADOOP-19079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17833717#comment-17833717
 ] 

ASF GitHub Bot commented on HADOOP-19079:
-----------------------------------------

pjfanning commented on PR #6557:
URL: https://github.com/apache/hadoop/pull/6557#issuecomment-2035365011

   > looks good, I am worried about overloaded methods though -we've had so 
many problems there in the past. the new method is good (one extra resilience 
change proposed) -but should we still use intercept() or give it a slightly 
different name.
   > 
   > we lifted the name from ScalaTest, if you've never played with that yet.
   
   I am very familiar with Scala test. I code mainly in Scala. Junit has 
assertThrows though. Would that be a bit more Java friendly?




> check that class that is loaded is really an exception
> ------------------------------------------------------
>
>                 Key: HADOOP-19079
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19079
>             Project: Hadoop Common
>          Issue Type: Task
>          Components: common, security
>            Reporter: PJ Fanning
>            Priority: Major
>              Labels: pull-request-available
>
> It can be dangerous taking class names as inputs from HTTP messages even if 
> we control the source. Issue is in HttpExceptionUtils in hadoop-common 
> (validateResponse method).
> I can provide a PR that will highlight the issue.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to