KeeProMise commented on code in PR #6697: URL: https://github.com/apache/hadoop/pull/6697#discussion_r1552627925
########## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcServer.java: ########## @@ -1089,13 +1089,7 @@ public DatanodeInfo[] getDatanodeReport(DatanodeReportType type) DatanodeInfo[] getCachedDatanodeReport(DatanodeReportType type) throws IOException { try { - DatanodeInfo[] dns = this.dnCache.get(type); - if (dns == null) { - LOG.debug("Get null DN report from cache"); - dns = getCachedDatanodeReportImpl(type); - this.dnCache.put(type, dns); - } - return dns; + return this.dnCache.get(type); Review Comment: @slfan1989 @ayushtkn Thanks for your review, this modification is just to test whether spotbug will pass. Why do I still get a spotbugs exception after deleting the relevant code? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org