[ https://issues.apache.org/jira/browse/HADOOP-19140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834454#comment-17834454 ]
ASF GitHub Bot commented on HADOOP-19140: ----------------------------------------- mukund-thakur commented on code in PR #6703: URL: https://github.com/apache/hadoop/pull/6703#discussion_r1554373273 ########## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/IORateLimiterSupport.java: ########## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.fs.impl; + +import org.apache.hadoop.fs.IORateLimiter; +import org.apache.hadoop.fs.Path; +import org.apache.hadoop.util.RateLimiting; +import org.apache.hadoop.util.RateLimitingFactory; + +import static org.apache.hadoop.util.Preconditions.checkArgument; + +/** + * Implementation support for {@link IORateLimiter}. + */ +public final class IORateLimiterSupport { Review Comment: This is just a wrapper on top of RestrictedRateLimiting with extra operation name validation right? I think this can be extended to limit per operation. > [ABFS, S3A] Add IORateLimiter api to hadoop common > -------------------------------------------------- > > Key: HADOOP-19140 > URL: https://issues.apache.org/jira/browse/HADOOP-19140 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs, fs/azure, fs/s3 > Affects Versions: 3.4.0 > Reporter: Steve Loughran > Assignee: Steve Loughran > Priority: Minor > Labels: pull-request-available > > Create a rate limiter API in hadoop common which code (initially, manifest > committer, bulk delete).. can request iO capacity for a specific operation. > this can be exported by filesystems so support shared rate limiting across > all threads > pulled from HADOOP-19093 PR -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org