[ 
https://issues.apache.org/jira/browse/HADOOP-16822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835724#comment-17835724
 ] 

ASF GitHub Bot commented on HADOOP-16822:
-----------------------------------------

pan3793 commented on PR #6719:
URL: https://github.com/apache/hadoop/pull/6719#issuecomment-2047470996

   @steveloughran One thing not related to this patch. I saw lots of Hadoop 
ecosystem projects using Yetus, but its comments are too too too long, 
actually, GitHub supports the collapsed format, which may improve the reviewer 
experience.
   
   
https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/organizing-information-with-collapsed-sections




> Provide source artifacts for hadoop-client-api
> ----------------------------------------------
>
>                 Key: HADOOP-16822
>                 URL: https://issues.apache.org/jira/browse/HADOOP-16822
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 3.3.1, 3.4.0, 3.2.3
>            Reporter: Karel Kolman
>            Assignee: Karel Kolman
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 3.3.1, 3.4.0, 3.2.3
>
>         Attachments: HADOOP-16822-hadoop-client-api-source-jar.patch
>
>
> h5. Improvement request
> The third-party libraries shading hadoop-client-api (& hadoop-client-runtime) 
> artifacts are super useful.
>  
> Having uber source jar for hadoop-client-api (maybe even 
> hadoop-client-runtime) would be great for downstream development & debugging 
> purposes.
> Are there any obstacles or objections against providing fat jar with all the 
> hadoop client api as well ?
> h5. Dev links
> - *maven-shaded-plugin* and its *shadeSourcesContent* attribute
> - 
> https://maven.apache.org/plugins/maven-shade-plugin/shade-mojo.html#shadeSourcesContent
> h2. Update April 2024: this has been reverted.
> It turns out that it complicates debugging. If you want the source when 
> debugging, the best way is just to check out the hadoop release you are 
> working with and point your IDE at it.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to