ayushtkn commented on code in PR #6721: URL: https://github.com/apache/hadoop/pull/6721#discussion_r1561813524
########## hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/PeerCache.java: ########## @@ -155,7 +155,7 @@ public Peer get(DatanodeID dnId, boolean isDomain) { private synchronized Peer getInternal(DatanodeID dnId, boolean isDomain) { List<Value> sockStreamList = multimap.get(new Key(dnId, isDomain)); - if (sockStreamList == null) { + if (sockStreamList.isEmpty()) { return null; Review Comment: We can just drop this if check itself, the below logic can safely handle an empty list -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org