anmolanmol1234 commented on code in PR #6633: URL: https://github.com/apache/hadoop/pull/6633#discussion_r1562462047
########## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClientThrottlingIntercept.java: ########## @@ -124,23 +125,24 @@ static AbfsClientThrottlingIntercept initializeSingleton(AbfsConfiguration abfsC * @return true if the operation is throttled and has some bytes to transfer. */ private boolean updateBytesTransferred(boolean isThrottledOperation, - HttpOperation abfsHttpOperation) { + AbfsHttpOperation abfsHttpOperation) { return isThrottledOperation && abfsHttpOperation.getExpectedBytesToBeSent() > 0; } /** * Updates the metrics for successful and failed read and write operations. + * * @param operationType Only applicable for read and write operations. - * @param abfsHttpOperation Used for status code and data transferred. + * @param httpOperation Used for status code and data transferred. Review Comment: nit : param name can be kept abfsHttpOperation only -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org