KeeProMise commented on code in PR #6727: URL: https://github.com/apache/hadoop/pull/6727#discussion_r1564577262
########## hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/fairness/ProportionRouterRpcFairnessPolicyController.java: ########## @@ -93,7 +93,8 @@ public boolean acquirePermit(String nsId) { public void releasePermit(String nsId) { if (contains(nsId)) { super.releasePermit(nsId); + } else { + super.releasePermit(DEFAULT_NS); } Review Comment: hi, LGTM. Personal opinion, whether it can be written like this. ```java if (contains(nsId)) { super.releasePermit(nsId); return; } super.releasePermit(DEFAULT_NS); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org