[ 
https://issues.apache.org/jira/browse/HADOOP-19103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840614#comment-17840614
 ] 

ASF GitHub Bot commented on HADOOP-19103:
-----------------------------------------

hadoop-yetus commented on PR #6615:
URL: https://github.com/apache/hadoop/pull/6615#issuecomment-2076140834

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   |||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m 00s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  spotbugs  |   0m 01s |  |  spotbugs executables are not 
available.  |
   | +0 :ok: |  codespell  |   0m 01s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m 01s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m 00s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m 00s |  |  The patch appears to 
include 1 new or modified test files.  |
   |||| _ trunk Compile Tests _ |
   | +1 :green_heart: |  mvninstall  | 106m 34s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |   5m 51s |  |  trunk passed  |
   | +1 :green_heart: |  checkstyle  |   5m 17s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   5m 45s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   5m 24s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  | 168m 41s |  |  branch has no errors 
when building and testing our client artifacts.  |
   |||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 37s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |   2m 40s |  |  the patch passed  |
   | +1 :green_heart: |  javac  |   2m 40s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m 00s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  checkstyle  |   2m 24s |  |  the patch passed  |
   | +1 :green_heart: |  mvnsite  |   2m 49s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |   2m 31s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  | 184m 37s |  |  patch has no errors 
when building and testing our client artifacts.  |
   |||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   6m 13s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 487m 07s |  |  |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | GITHUB PR | https://github.com/apache/hadoop/pull/6615 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
   | uname | MINGW64_NT-10.0-17763 634fe718ba01 3.4.10-87d57229.x86_64 
2024-02-14 20:17 UTC x86_64 Msys |
   | Build tool | maven |
   | Personality | /c/hadoop/dev-support/bin/hadoop.sh |
   | git revision | trunk / f7bfc5e8adb758bda80818d15721fc271fc0d7ff |
   | Default Java | Azul Systems, Inc.-1.8.0_332-b09 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6615/1/testReport/
 |
   | modules | C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws |
   | Console output | 
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6615/1/console
 |
   | versions | git=2.44.0.windows.1 |
   | Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> Add logic for verifying that the STS URL is in the correct format
> -----------------------------------------------------------------
>
>                 Key: HADOOP-19103
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19103
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs/s3
>            Reporter: Narayanan Venkateswaran
>            Priority: Minor
>              Labels: pull-request-available
>
> * At present an invalid URL can be supplied as an STS endpoint. It will 
> attempt to create an STSClient with it and then fail with,
> {quote}java.net.UnknownHostException: request session credentials: 
> software.amazon.awssdk.core.exception.SdkClientException: Received an 
> UnknownHostException when attempting to interact with a service. See cause 
> for the exact endpoint that is failing to resolve. If this is happening on an 
> endpoint that previously worked, there may be a network connectivity issue or 
> your DNS cache could be storing endpoints for too long.:    
> software.amazon.awssdk.core.exception.SdkClientException: Received an 
> UnknownHostException when attempting to interact with a service. See cause 
> for the exact endpoint that is failing to resolve. If this is happening on an 
> endpoint that previously worked, there may be a network connectivity issue or 
> your DNS cache could be storing endpoints for too long.: https
> {quote} * This is inefficient. An invalid URL can be parsed much earlier and 
> can be failed based on the URL format itself.
>  * The error message is not very clear and does not indicate a problem in the 
> URL format.
>  * In this Jira issue, we attempt to parse the STS URL and fail fast with a 
> more relevant error message.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to