[ 
https://issues.apache.org/jira/browse/HADOOP-19137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840673#comment-17840673
 ] 

ASF GitHub Bot commented on HADOOP-19137:
-----------------------------------------

saxenapranav commented on code in PR #6752:
URL: https://github.com/apache/hadoop/pull/6752#discussion_r1578968010


##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java:
##########
@@ -373,7 +372,21 @@ public boolean getIsNamespaceEnabled(TracingContext 
tracingContext)
           + " getAcl server call", e);
     }
 
-    isNamespaceEnabled = 
Trilean.getTrilean(NamespaceUtil.isNamespaceEnabled(client, tracingContext));
+    try {
+      LOG.debug("Get root ACL status");

Review Comment:
   This class was actually introduced in CPK pr: 
https://github.com/apache/hadoop/pull/6221/files#diff-aed851febeaa85ad9b0c254c00ebd21200b84d36bc99255a344db89319aab0b0.
   
   Reason for adding this class was that we wanted to check namespace 
information in abfsClient and store. This is no more required, as we would need 
the information in store.
   
   Reason for removing this class is to bring in the state which was before-cpk 
merge.





> [ABFS]:Extra getAcl call while calling the very first API of FileSystem
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-19137
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19137
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/azure
>    Affects Versions: 3.4.0
>            Reporter: Pranav Saxena
>            Assignee: Pranav Saxena
>            Priority: Major
>              Labels: pull-request-available
>
> Store doesn't flow in the namespace information to the client. 
> In https://github.com/apache/hadoop/pull/6221, getIsNamespaceEnabled is added 
> in client methods which checks if namespace information is there or not, and 
> if not there, it will make getAcl call and set the field. Once the field is 
> set, it would be used in future getIsNamespaceEnabled method calls for a 
> given AbfsClient.
> Since, CPK both global and encryptionContext are only for hns account, the 
> fix that is proposed is that we would fail fs init if its non-hns account and 
> cpk config is given.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to