kokonguyen191 commented on code in PR #6759: URL: https://github.com/apache/hadoop/pull/6759#discussion_r1582197257
########## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPOfferService.java: ########## @@ -324,6 +325,10 @@ private void notifyNamenodeBlock(ExtendedBlock block, BlockStatus status, final ReceivedDeletedBlockInfo info = new ReceivedDeletedBlockInfo( block.getLocalBlock(), status, delHint); final DatanodeStorage storage = dn.getFSDataset().getStorage(storageUuid); + if (storage == null) { Review Comment: Good idea. Better to stop it here rather than let the code propagate further down. I'll change it later once I charge my laptop. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org