KeeProMise commented on PR #6622: URL: https://github.com/apache/hadoop/pull/6622#issuecomment-2100839456
> Was gonna hit the merge button, but got curious. > > Earlier if the value was 1, was it an infinite loop always? or in just in a corner case, if in just one corner case & now if we throw an exception, if anyone has value of 1 earlier his jobs would be working but post this change it would fail? > > can we just break the condition for infinite loop if that is the case & preserve the value? or at worst if that is an illegal value, we put a warn log & use the defaul? > > @brumi1024 / @szilard-nemeth any pointers? @ayushtkn hi, to prevent throwing exceptions from affecting the task, I will print a warning log instead of throwing exceptions. Please take a look again, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
