hfutatzhanghb commented on code in PR #6765: URL: https://github.com/apache/hadoop/pull/6765#discussion_r1597392676
########## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java: ########## @@ -1105,15 +1106,12 @@ static void unprotectedUpdateCount(INodesInPath inodesInPath, /** * Update the cached quota space for a block that is being completed. * Must only be called once, as the block is being completed. - * @param completeBlk - Completed block for which to update space - * @param inodes - INodes in path to file containing completeBlk; if null - * this will be resolved internally + * @param commitBlock - Committed block for which to update space + * @param iip - INodes in path to file containing committedBlock */ - public void updateSpaceForCompleteBlock(BlockInfo completeBlk, - INodesInPath inodes) throws IOException { + public void updateSpaceForCommittedBlock(Block commitBlock, Review Comment: Which could be better parameter name : commitBlock or committedBlock? ########## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java: ########## @@ -3887,7 +3887,11 @@ void commitOrCompleteLastBlock( final Block commitBlock) throws IOException { assert hasWriteLock(); Preconditions.checkArgument(fileINode.isUnderConstruction()); - blockManager.commitOrCompleteLastBlock(fileINode, commitBlock, iip); + if (!blockManager.commitOrCompleteLastBlock(fileINode, commitBlock)) { + return; + } + // Updating QuotaUsage when committing block since block size will not be changed + getFSDirectory().updateSpaceForCommittedBlock(commitBlock, iip); Review Comment: Sir, How about ```java if (blockManager.commitOrCompleteLastBlock(fileINode, commitBlock)) { // Updating QuotaUsage when committing block since block size will not be changed getFSDirectory().updateSpaceForCommittedBlock(commitBlock, iip); } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org