vinayakumarb commented on code in PR #6809:
URL: https://github.com/apache/hadoop/pull/6809#discussion_r1597693783
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java:
##########
@@ -626,7 +626,8 @@ private synchronized boolean checkLeases(Collection<Lease>
leasesToCheck) {
}
}
// If a lease recovery happened, we need to sync later.
Review Comment:
This is a nice hack. But this will not handle the case, where actual
recovery of the file is triggered and lease is reassigned.
Lease re-assignment also will have a edit log. This also should be synced as
well.
I would recommend you to change the return type of `internalReleaseLease()`
to `ImmutablePair<Boolean, Boolean>` to include both `completed` and `needSync`
values.
needSync will be true in both cases of file closed and lease re-assignment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
