anujmodi2021 commented on code in PR #6752:
URL: https://github.com/apache/hadoop/pull/6752#discussion_r1597905780
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystem.java:
##########
@@ -223,6 +225,21 @@ public void initialize(URI uri, Configuration
configuration)
}
}
+ if ((abfsConfiguration.createEncryptionContextProvider() != null
+ || StringUtils.isNotEmpty(
Review Comment:
Any specific reason to use StringUtils here??
Can we instead do?
```!abfsConfiguration.getEncodedClientProvidedEncryptionKey().isEmpty()```
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java:
##########
@@ -373,7 +372,21 @@ public boolean getIsNamespaceEnabled(TracingContext
tracingContext)
+ " getAcl server call", e);
}
- isNamespaceEnabled =
Trilean.getTrilean(NamespaceUtil.isNamespaceEnabled(client, tracingContext));
+ try {
+ LOG.debug("Get root ACL status");
Review Comment:
I think its okay to get rid of this class.
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/constants/AbfsHttpConstants.java:
##########
@@ -165,5 +165,8 @@ public static ApiVersion getCurrentVersion() {
*/
public static final Integer HTTP_STATUS_CATEGORY_QUOTIENT = 100;
+ public static final String FS_INIT_FAILED_CPK_CONFIG_IN_NON_HNS_ACCOUNT =
Review Comment:
Nit: This is an error message right??
Should it be named to reflect that??
CPK_IN_NON_HNS_ACCOUNT_ERROR_MESSAGE
Just a thought
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
