ZanderXu commented on code in PR #6784: URL: https://github.com/apache/hadoop/pull/6784#discussion_r1598226242
########## hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterRpc.java: ########## @@ -1224,6 +1239,26 @@ public void testProxyConcatFile() throws Exception { String badPath = "/unknownlocation/unknowndir"; compareResponses(routerProtocol, nnProtocol, m, new Object[] {badPath, new String[] {routerFile}}); + + // Test when concat trg is a empty file + createFile(routerFS, existingFile, existingFileSize); + String sameRouterEmptyFile = + cluster.getFederatedTestDirectoryForNS(sameNameservice) + + "_newemptyfile"; + createFile(routerFS, sameRouterEmptyFile, 0); + // Concat in same namespaces, succeeds + testConcat(existingFile, sameRouterEmptyFile, false); + FileStatus mergedStatus = getFileStatus(routerFS, sameRouterEmptyFile); + assertEquals(existingFileSize, mergedStatus.getLen()); + + // Test when concat srclist has some empty file, namenode will throw IOException. + String srcEmptyFile = cluster.getFederatedTestDirectoryForNS(sameNameservice) + "_srcEmptyFile"; + createFile(routerFS, srcEmptyFile, 0); + String targetFile = cluster.getFederatedTestDirectoryForNS(sameNameservice) + "_targetFile"; + createFile(routerFS, targetFile, existingFileSize); + // Concat in same namespaces, succeeds + testConcat(srcEmptyFile, targetFile, true, true, Review Comment: here please check if the exception is `org.apache.hadoop.ipc.RemoteException(org.apache.hadoop.HadoopIllegalArgumentException)` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org