ZanderXu commented on code in PR #6833:
URL: https://github.com/apache/hadoop/pull/6833#discussion_r1611258872
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/CachedRecordStore.java:
##########
@@ -198,8 +195,15 @@ public void overrideExpiredRecords(QueryResult<R> query)
throws IOException {
if (commitRecords.size() > 0) {
getDriver().putAll(commitRecords, true, false);
}
- if (deleteRecords.size() > 0) {
- newRecords.removeAll(deleteRecords);
+ if (!toDeleteRecords.isEmpty()) {
+ for (Map.Entry<R, Boolean> entry :
getDriver().removeMultiple(toDeleteRecords).entrySet()) {
+ if (entry.getValue()) {
+ deletedRecords.add(entry.getKey());
Review Comment:
Here changing to `newRecords.remove(entry.getKey())`, we can remove
`deletedRecords`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
