steveloughran commented on code in PR #6631: URL: https://github.com/apache/hadoop/pull/6631#discussion_r1669017356
########## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/IOStreamPair.java: ########## @@ -23,10 +23,12 @@ import java.io.OutputStream; import org.apache.hadoop.classification.InterfaceAudience; +import org.apache.hadoop.classification.InterfaceStability; import org.apache.hadoop.io.IOUtils; /** * A little struct class to wrap an InputStream and an OutputStream. + * Inputstream and OutputStream are closed on close call. Review Comment: 1. maybe the history of this class should be described as in "moved from hdfs to hadoop-common so yarn can remove HDFS dependencies" 2. And add that package-info.java file, mark the whole package as InterfaceAudience.Private ########## hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/IOStreamPair.java: ########## @@ -23,10 +23,12 @@ import java.io.OutputStream; import org.apache.hadoop.classification.InterfaceAudience; +import org.apache.hadoop.classification.InterfaceStability; Review Comment: cut this as it is tagged as private -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
