[
https://issues.apache.org/jira/browse/HADOOP-8275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13262229#comment-13262229
]
Eli Collins commented on HADOOP-8275:
-------------------------------------
Maybe update the jira subject to "readVInt range checking to restrict
DelegateKey len to 1mb" or similar?
Nits:
- {{MAX_KEY_LEN = 1024*1024}} would be more readable
- @return javadocs don't get periods (readVIntInRange)
For sanity, check the impact on the load time of a large edit log since
readVInt is called frequently? Otherwise looks great!
> harden serialization logic against malformed or malicious input
> ---------------------------------------------------------------
>
> Key: HADOOP-8275
> URL: https://issues.apache.org/jira/browse/HADOOP-8275
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.23.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HADOOP-8275.001.patch, HADOOP-8275.002.patch
>
>
> harden serialization logic against malformed or malicious input
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
