zhengchenyu commented on PR #6896: URL: https://github.com/apache/hadoop/pull/6896#issuecomment-2310436077
@lfxy you does not catch me. I said the same thing as you said. My (1) is just your (1) -> (2), My (2) is just your (4) -> (5). I suggest checking in (4)->(5). Although we filter out timed out blocks in (1) -> (2), we still need to add these block in (4) -> (5). We can do the check in (4) -> (5). Generally speaking, the verification cost in (4) -> (5) is lower, because there are fewer blocks to check. And there is no need to change timedOutItems from List to Set. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
