steveloughran commented on code in PR #6876: URL: https://github.com/apache/hadoop/pull/6876#discussion_r1738397101
########## hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/assumed_roles.md: ########## @@ -153,6 +153,14 @@ Here are the full set of configuration options. </description> </property> +<property> + <name>fs.s3a.assumed.role.external.id</name> + <value /> + <description> + External id for assumed role, it's an optional configuration. + </description> Review Comment: insert a link to https://aws.amazon.com/blogs/security/how-to-use-external-id-when-granting-access-to-your-aws-resources/ ########## hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/assumed_roles.md: ########## @@ -153,6 +153,14 @@ Here are the full set of configuration options. </description> </property> +<property> + <name>fs.s3a.assumed.role.external.id</name> + <value /> Review Comment: can you an a valid example ########## hadoop-common-project/hadoop-common/src/main/resources/core-default.xml: ########## @@ -1457,6 +1457,14 @@ </description> </property> +<property> Review Comment: lets actually cut this. Adding default values here increases the size of the configuration when marshalling, which happens a lot these days. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
