[ https://issues.apache.org/jira/browse/HADOOP-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264335#comment-13264335 ]
Hadoop QA commented on HADOOP-8325: ----------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12524980/HADOOP-8325.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.io.TestSequenceFile +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/903//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/903//console This message is automatically generated. > Add a ShutdownHookManager to be used by different components instead of the > JVM shutdownhook > -------------------------------------------------------------------------------------------- > > Key: HADOOP-8325 > URL: https://issues.apache.org/jira/browse/HADOOP-8325 > Project: Hadoop Common > Issue Type: Bug > Components: fs > Affects Versions: 2.0.0 > Reporter: Alejandro Abdelnur > Assignee: Alejandro Abdelnur > Priority: Critical > Fix For: 2.0.0 > > Attachments: HADOOP-8325.patch, HADOOP-8325.patch, HADOOP-8325.patch, > HADOOP-8325.patch, HADOOP-8325.patch, HADOOP-8325.patch, HADOOP-8325.patch > > > FileSystem adds a JVM shutdown hook when a filesystem instance is cached. > MRAppMaster also uses a JVM shutdown hook, among other things, the > MRAppMaster JVM shutdown hook is used to ensure state are written to HDFS. > This creates a race condition because each JVM shutdown hook is a separate > thread and if there are multiple JVM shutdown hooks there is not assurance of > order of execution, they could even run in parallel. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira